Re: [PATCH] Highlight keyboard shortcuts in git-add--interactive

El 29/11/2007, a las 0:56, Junio C Hamano escribió:

Wincent Colaiuta [off-list ref] writes:

quoted

@@ -774,14 +774,14 @@ EOF

}

sub main_loop {
-	my @cmd = ([ 'status', \&status_cmd, ],
-		   [ 'update', \&update_cmd, ],
-		   [ 'revert', \&revert_cmd, ],
-		   [ 'add untracked', \&add_untracked_cmd, ],
-		   [ 'patch', \&patch_update_cmd, ],
-		   [ 'diff', \&diff_cmd, ],
-		   [ 'quit', \&quit_cmd, ],
-		   [ 'help', \&help_cmd, ],
+	my @cmd = ([ 'status', \&status_cmd, '[s]tatus', ],
+		   [ 'update', \&update_cmd, '[u]date', ],
+		   [ 'revert', \&revert_cmd, '[r]evert', ],
+		   [ 'add untracked', \&add_untracked_cmd, '[a]dd untracked', ],
+		   [ 'patch', \&patch_update_cmd, '[p]atch', ],
+		   [ 'diff', \&diff_cmd, '[d]iff', ],
+		   [ 'quit', \&quit_cmd, '[q]uit', ],
+		   [ 'help', \&help_cmd, '[h]elp', ],
	);

I like the general idea of making it more obvious that you can use the
unique prefix, but I think you should make list_and_choose do this
automatically without adding a redundant element in the command array.

If you do so, the same highlighting will automatically appear when you
are picking which paths to update in the update subcommand, for  
example.

Yes, I did consider that, and it's very easy when all the options have  
a unique, single-letter prefix, as is the case with the main command  
loop. But what to do if you've got a bunch of paths with lengthy  
common prefixes? eg. what would you highlight here?

lib/ssl/crypto/foo.c
lib/ssl/crypto/bar.c
lib/ssl/crypto/baz.c

Highlighting "lib/ssl/crypto/f", "lib/ssl/crypto/bar" and "lib/ssl/ 
crypto/baz" doesn't sound like much help... Maybe there should be some  
limit: if you need to go more than 3 characters deep in order to  
differentiate unique prefixes then perhaps highlighting should be  
omitted in that case. What do you think of that idea?

Cheers,
Wincent