Thread (3 messages) flat view 3 messages, 2 authors, 2016-06-15

Re: [PATCH 2/3] cvsimport: use show-ref to support packed refs

From: Jeff King <hidden>
Date: 2016-06-15 22:43:54

On Wed, Nov 28, 2007 at 05:43:13PM -0500, Jeff King wrote:
quoted
	sub get_headref {
        	my ($it) = (@_);
                my $r = `git-rev-parse --verify "refs/$it"`;
		return undef unless $? == 0;
		chomp $r;
		return $r;
	}
I have no comment on which is the best command to use (you would know
much better than I), but adding "refs/" is wrong.
BTW, one bad thing about the new get_headref compared to the original is
that it does not distinguish very well between "ref does not exist" and
"an error occurred." Is there a lookup command that makes such a
distinction possible?

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help