Re: [PATCH] gitview: revamped to use string.join, stripped a function def

Signed-off-by: Denis Cheng <redacted>
---
 contrib/gitview/gitview |   13 +------------
 1 files changed, 1 insertions(+), 12 deletions(-)

diff --git a/contrib/gitview/gitview b/contrib/gitview/gitview
index 5931766..2eb72b1 100755
--- a/contrib/gitview/gitview
+++ b/contrib/gitview/gitview

@@ -36,17 +36,6 @@ except ImportError:

 re_ident = re.compile('(author|committer) (?P<ident>.*) (?P<epoch>\d+) (?P<tz>[+-]\d{4})')

-def list_to_string(args, skip):
-       count = len(args)
-       i = skip
-       str_arg=" "
-       while (i < count ):
-               str_arg = str_arg + args[i]
-               str_arg = str_arg + " "
-               i = i+1
-
-       return str_arg
-
 def show_date(epoch, tz):
        secs = float(epoch)
        tzsecs = float(tz[1:3]) * 3600

@@ -1115,7 +1104,7 @@ class GitView(object):

        def set_branch(self, args):
                """Fill in different windows with info from the reposiroty"""
-               fp = os.popen("git rev-parse --sq --default HEAD " + list_to_string(args, 1))
+               fp = os.popen("git rev-parse --sq --default HEAD " + " ".join(args[1:]))
                git_rev_list_cmd = fp.read()
                fp.close()
                fp = os.popen("git rev-list  --header --topo-order --parents " + git_rev_list_cmd)
--

1.5.3.2