Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] Fix start_command closing cmd->out/in regardless of cmd->close_out/in

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:52

Ping Yin [off-list ref] writes:
When 'FILE *fp' is assigned to child_process.out and then start_command or
run_command is run, the standard output of the child process is expected to
be outputed to fp. However, sometimes fp is not expected to be closed since
further IO may be still performmed on fp.
Could you clarify "However, sometimes" with a concrete codepath
that has this problem in the proposed commit log message, and
Sign-off your patch please?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help