Thread (7 messages) flat view 7 messages, 3 authors, 2016-06-15

Re: [PATCH] Fix t7004 which fails with retarded sed

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:52

Possibly related (same subject, not in this thread)

Mike Hommey [off-list ref] writes:
quoted
So the earlier part of the test

	GIT_EDITOR=cat git tag -a initial-comment > actual || true &&

is already bogus with respect to the latter point.  It will
happily continue if "git tag" erroneously returns success, and
the above does not catch it.

	if GIT_EDITOR=cat git tag -a initial-comment >actual
        then
        	echo >&2 oops we should have errored out
                false
	else
        	: happy -- anything else we want to check?
	fi
This should probably be tested in another test block.
Fair enough; please make it so.
Which is roughly what my patch does, except it doesn't check for
ordering.
... which I think is more important part.  If the blank like
were at the end, that would be irritating for the user, wouldn't
it?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help