Re: [PATCH] Improved and extended t5404

Alex Riesen [off-list ref] writes:

Junio C Hamano, Wed, Nov 14, 2007 01:02:20 +0100:

quoted

Alex Riesen [off-list ref] writes:

quoted

Ignore exit code of git push in t5404, as it is not relevant for the
test

This proposed log message solicits a "Huh? -- Since when
ignoring exit code is an improvement?" reaction.  If this push
is expected to error out, then wouldn't you want to make sure it
errors out as expected?  If the problem is that the exit status
is unreliable, maybe we need to make it reliable instead?

Well, it is kind of undefined. git push just updated some remote
references and failed on the others. It has had some failures, so it
returns non-0. And as I said, it really is not about the operation,
but about if the tracking and remote branches are set as we want them.

Ok, I guess the proposed log message was not clear enough, at
least for me.

Will apply.