Re: [PATCH] t7005-editor.sh: Don't invoke real vi when it is in GIT_EXEC_PATH

Hi Brian, hi Björn,

On Sun, 11 Nov 2007, Brian Gernhardt wrote:

On Nov 11, 2007, at 12:44 PM, Johannes Schindelin wrote:

quoted

Probably git-commit executes your installed write-tree, commit-tree 
and friends, instead of the compiled ones.

You are wrong there.  From exec_cmd.c:setup_path() (lines 51-54):

   add_path(&new_path, argv_exec_path);
   add_path(&new_path, getenv(EXEC_PATH_ENVIRONMENT));
   add_path(&new_path, builtin_exec_path);
   add_path(&new_path, cmd_path);

Ah, I forgot that --exec-path=<path> did not override GIT_EXEC_PATH.  
Thanks for clarifying!  Your patch is obviously good, then.

Ciao,
Dscho