Thread (1 message) 1 message, 1 author, 2016-06-15

Re: *[PATCH 2/2] Let git-add--interactive read colors from .gitconfig

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:46

Dan Zwell [off-list ref] writes:
Junio C Hamano [off-list ref] wrote:
...
quoted
In addition to a small matter of testing, a more practical issue
would be to add PAGER support there, I think.
You mean in general, so that users can view a hunk in the PAGER, then
be prompted for what to do with it? (Because it doesn't solve the color
problems, because calling "diff --color" here creates other problems.)
Yes.  I see it a much bigger problem that we let a long hunk
scroll off the top of the screen then ask the user what to do
with it, than any coloring of diff.
... but it does not highlight
whitespace at the end of lines or space/tab errors.
No, but you can make it so if you want.

Personally, I think it is not so useful for "add -i" to do so,
as it is too late in the workflow, unless you add it ways to let
you edit and fix the whitespace errors.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help