Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 1/4] Add testcase for ammending and fixing author in git commit.

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:46

Kristian Høgsberg [off-list ref] writes:
quoted
This can't be right.  How are you ignoring the differences in
committer dates?
t/test-lib.sh fixes GIT_COMMITTER_DATE so all commits have the date

committer C O Mitter [off-list ref] 1112911993 -0700

unless you use test_tick.
Heh, that was actually what I was getting at.  By not doing
test_tick, you are not making sure that the commit gets the
timestamp of the time --amend is run.
quoted
By the way, I _think_ git-commit.sh allows fixing author name/email
without molesting the author timestamp (i.e. takes it from the
amended commit).  That should probably be checked with the test
as well.
You're right, I need to pick GIT_AUTHOR_DATE from the ammended commit.
Ok, I'll need to rewrite determine_author_info() a little bit.  I might
get an update patch out this weekend.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help