[PATCH 1/4] Add testcase for ammending and fixing author in git commit. · Kristian Høgsberg <hidden> · 2016-06-15
[PATCH 2/4] Remove unecessary hard-coding of EDITOR=':' VISUAL=':' in some test suites. · Kristian Høgsberg <hidden> · 2016-06-15
[PATCH 3/4] Export launch_editor() and make it accept ':' as a no-op editor. · Kristian Høgsberg <hidden> · 2016-06-15
[PATCH 4/4] Implement git commit and status as a builtin commands. · Kristian Høgsberg <hidden> · 2016-06-15
Re: [PATCH 4/4] Implement git commit and status as a builtin commands. · Johannes Schindelin <hidden> · 2016-06-15
Re: [PATCH 4/4] Implement git commit and status as a builtin commands. · Kristian Høgsberg <hidden> · 2016-06-15
Re: [PATCH 4/4] Implement git commit and status as a builtin commands. · Björn Steinbrink <hidden> · 2016-06-15
Re: [PATCH 4/4] Implement git commit and status as a builtin commands. · Kristian Høgsberg <hidden> · 2016-06-15
Re: [PATCH 4/4] Implement git commit and status as a builtin commands. · Björn Steinbrink <hidden> · 2016-06-15
Re: [PATCH 4/4] Implement git commit and status as a builtin commands. · Johannes Schindelin <hidden> · 2016-06-15
Re: [PATCH 4/4] Implement git commit and status as a builtin commands. · Björn Steinbrink <hidden> · 2016-06-15
Re: [PATCH 4/4] Implement git commit and status as a builtin commands. · Kristian Høgsberg <hidden> · 2016-06-15
Re: [PATCH 4/4] Implement git commit and status as a builtin commands. · Björn Steinbrink <hidden> · 2016-06-15
Re: [PATCH 4/4] Implement git commit and status as a builtin commands. · Pierre Habouzit <hidden> · 2016-06-15
Re: [PATCH 4/4] Implement git commit and status as a builtin commands. · Johannes Sixt <hidden> · 2016-06-15
Re: [PATCH 4/4] Implement git commit and status as a builtin commands. · Pierre Habouzit <hidden> · 2016-06-15
Re: [PATCH 4/4] Implement git commit and status as a builtin commands. · Andreas Ericsson <hidden> · 2016-06-15
Re: [PATCH 4/4] Implement git commit and status as a builtin commands. · Kristian Høgsberg <hidden> · 2016-06-15
Re: [PATCH 3/4] Export launch_editor() and make it accept ':' as a no-op editor. · Andreas Ericsson <hidden> · 2016-06-15
Re: [PATCH 3/4] Export launch_editor() and make it accept ':' as a no-op editor. · Kristian Høgsberg <hidden> · 2016-06-15

Re: [PATCH 3/4] Export launch_editor() and make it accept ':' as a no-op editor.

From: Andreas Ericsson <hidden>
Date: 2016-06-15 22:43:46

Kristian Høgsberg wrote:

quoted hunk ↗ jump to hunk

 
+	if (!strcmp(editor, ":"))
+		return;
+

Doesn't this make the change in 2/4 superfluous?

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help