Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] Implement git commit as a builtin command.

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:46

Kristian Høgsberg [off-list ref] writes:
Move git-commit.sh to contrib/examples.

Signed-off-by: Kristian Høgsberg <redacted>
---

Here's the builtin-commit patch again, this time updated to build
against the in-tree strbuf and option parser.  Now that Pierre has
done all the work of getting those pieces upstream, I notice that the
C version ends up 20 lines shorter than the shell script :)

There's a couple of changes to the test suite at the end, which
removes some EDITOR=: VISUAL=: hard-coding in a few tests and then
sets the default editor to /bin/true.  This is to address the problem
that the C version of launch editor doesn't support any kind of shell
qouting or built-ins.  Should we just use system(3) here?
I do not care much about _how_ it is done, but one of the most
often typed command in my .history is

	EDITOR=: git commit

I'd be somewhat unhappy to be forced to retrain my fingers ;-)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help