Re: [PATCH 1/1] Add --first-parent support to interactive rebase.

On 2007.10.31 14:05:57 -0400, Jeff King wrote:

On Wed, Oct 31, 2007 at 05:36:41PM +0300, Dmitry Potapov wrote:

quoted

Hmm... I looked at the mail again and I cannot see where 8859-1 is
specified. It seems that context encoding is not specified at all.
Of course, it is incorrect to use non ASCII characters in a mail
without specifying encoding. Apparently, because I use utf-8 in the
terminal, the Sign-off line displays correctly for me, so I did not
notice the problem. Sorry for the noise...

It is our old friend vger adding the iso-8859-1 header, I think, since
no encoding was specified.

I think the problem is that git-format-patch only decides whether to
append a MIME header based on the commit message contents; it does not
take the Signed-Off-By into account. This may also be the cause of the
recent complaints from Matti Aarnio.

Yep, that's it. If the Signed-Off-By was added by commit -s, it works,
while format-patch -s causes the header to be missing, although the
Signed-Off-By is utf-8 encoded. Will try to remember that.

Thanks,
Björn