Re: [GIT-GUI PATCH 2/3] po2msg: ignore untranslated messages
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:45
Johannes Schindelin [off-list ref] writes:
quoted hunk
Do not generate translations when the translated message is empty. Signed-off-by: Johannes Schindelin <redacted> --- po/po2msg.sh | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)diff --git a/po/po2msg.sh b/po/po2msg.sh index 48a2669..91d420b 100644 --- a/po/po2msg.sh +++ b/po/po2msg.sh@@ -62,6 +62,9 @@ proc flush_msg {} { if {$msgid == ""} { set prefix "set ::msgcat::header" } else { + if {$msgstr == ""} { + return + } set prefix "::msgcat::mcset $lang \"[u2a $msgid]\"" }
Is this change to fix some real issues? Sometimes it is handy to be able to translate a non-empty string into an empty one in one target language.