Thread (24 messages) flat view 24 messages, 7 authors, 2016-06-15

Re: [PATCH 5/9] git-cat-file: Add --separator option

From: Brian Downing <hidden>
Date: 2016-06-15 22:43:44

On Mon, Oct 22, 2007 at 10:46:33PM -0700, Adam Roben wrote:
+--separator::
+	A string to print in between the output for each object passed on
+	stdin. A newline will be appended to the separator each time it is
+	printed.
Maybe I'm just unreasonably paranoid, but I don't think I could ever
trust that you'd never find an arbitrary separator in the data.  I
suppose if you scanned the files beforehand you could come up with
something guaranteed to be unique, but that seems like a pain (and
doesn't happen regardless in patch 9/9; it just uses
"--------------GITCATFILESEPARATOR-----------")  If I were committing to
SVN, it's sure not something I'd like to bet the integrity of my data
on.

I think a far more reasonable output format for multiple objects would
be something like:

<count> LF
<raw data> LF

Where <count> is the number of bytes in the <raw data> as an ASCII
decimal integer.

This is pretty much the spiritual analog to the fast-import "exact byte
count" data input format as well.

-bcd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help