Re: What's cooking in git/spearce.git (topics)

On Mon, Oct 22, 2007 at 07:32:02PM -0700, Linus Torvalds wrote:

Your patch is better than what used to be there, but

quoted

-			/* Already picked as a destination? */
+			/* Already picked as a source? */
 			if (!p->src_dst)
 				continue;

the above is wrong, the whole thing should be dropped (we *want* to be 
able to re-use sources).

Oops, you're right. I'm not sure what I was thinking.

Anyway, the set of fixes I sent out earlier included fixing that stupid 
loop as one of the things.

Looks like you have made some real progress. I'll try to review your
patch tonight, and hopefully make some progress on the inexact case.

-Peff