Re: [PATCH] git-config: print error message if the config file cannot be read
From: Johannes Sixt <hidden>
Date: 2016-06-15 22:43:40
Gerrit Pape schrieb:
quoted hunk ↗ jump to hunk
@@ -235,8 +235,12 @@ int cmd_config(int argc, const char **argv, const char *prefix) argv++; } - if (show_all) - return git_config(show_all_config); + if (show_all) { + if (git_config(show_all_config) == -1) + die("unable to read config file %s: %s", + getenv(CONFIG_ENVIRONMENT), strerror(errno));
I don't think that this works well: If there are no config files at all, then we don't want to see an error - just as if the config file were empty. Also, I don't think that errno is reliable at this point. You probably want to see an error message *only* if you have supplied a file name with --file. -- Hannes