Re: [PATCH] Support tags in uncommit - use git_id instead of rev_parse

On 02/10/2007, Pavel Roskin [off-list ref] wrote:

On Mon, 2007-10-01 at 23:00 +0100, Catalin Marinas wrote:

quoted

To allow tags, maybe just pass something like
"git.rev_parse(options.to + '^{commit}')" or just modify git.rev_parse
to do it (and git_id to avoid it).

I prefer to work with software that understands what I mean and tells me
that I cannot do it.  It makes it easier to understand what is possible
and how the command is working.

Recognizing patch names in some commands but not others would be
annoying and inconsistent.  Dumbing downs interactive software on
purpose is probably not worth the trouble.

Without this patch, the 'stg uncommit -t patch' fails with 'Unknown
revision: patch'. With the patch applied, it still fails but with
'Commit ... does not have exactly one parent'. I don't say that the
first one is good but I don't think the latter is clearer. The 'stg
uncommit --help' states that the '--to' option takes a commit argument
but if one passes a patch name the error message gets pretty
confusing.

-- 
Catalin