Re: [PATCH] rebase: add --signoff option
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:37
Steffen Prohaska [off-list ref] writes:
When preparing a series of commits for upstream you may need to signoff commits if you forgot to do so earlier. This patch teaches git-rebase to signoff during rebase if you pass the option --signoff. Notes 1) --signoff cannot be used simultaneously with --interactive. 2) --signoff forces a rebase even if current path is a descendant of <upstream>. Signed-off-by: Steffen Prohaska <redacted>
I do not think it is fatal for --signoff to be incompatible with the "interactive" mode is fatal, but lack of mention in the documentation is. Also this would need test scripts to prevent it from getting broken by future changes by others. I'd like to see ones that test at least the cases where (1) nobody has sign-off, (2) you do not have sign-off but others do, and (3) you already have sign-off at the end. But I do like the general concept.