Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH] alloc_ref(): allow for trailing NUL

From: Daniel Barkalow <hidden>
Date: 2016-06-15 22:43:37

On Fri, 28 Sep 2007, Johannes Schindelin wrote:
The parameter name "namelen" suggests that you pass the equivalent of
strlen() to the function alloc_ref().  However, this function did not
allocate enough space to put a NUL after the name.

Since struct ref does not have any member to describe the length of the
string, this just does not make sense.

So make space for the NUL.
Good point, but shouldn't you then fix call sites that use strlen(name) + 
1?

	-Daniel
*This .sig left intentionally blank*
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help