Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 2/4] This exports the update() function from builtin-add.c as

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:37

Johannes Schindelin [off-list ref] writes:
On Thu, 27 Sep 2007, Kristian Høgsberg wrote:
quoted
 builtin-add.c |    8 ++++----
 commit.h      |    2 ++
Maybe move it to read-cache.c, just after "add_file_to_index()"?  And 
expose it via cache.h, not commit.h?
Hmmmmmmmm.  read-cache.c has been one of the lowest level files
that define atomic operations, similar to sha1_file.c, and this
function is much more porcelain-ish molecule operation.  I'd
rather not.

What other useful molecules would we have and/or need to have by
splitting existing standalone commands?  rerere() is another,
and probably we would need to rip the --with-tree bit from
ls-files out to make it usable from builtin-commit.

I do not think we would want to go to the "one file per
function" extreme, either.  Can we have a new file that hold
these helper functions for porcelains?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help