Re: [PATCH] Supplant the "while case ... break ;; esac" idiom

"David Symonds" [off-list ref] writes:

On 24/09/2007, David Kastrup [off-list ref] wrote:

quoted

Mike Hommey [off-list ref] writes:

quoted

On Sun, Sep 23, 2007 at 10:42:08PM +0200, David Kastrup wrote:

quoted

-while case $# in 0) break ;; esac
+while test $# != 0

Wouldn't -ne be better ?

Why?

Because -ne does a numeric comparison, != does a string comparison,
and it's a numeric comparison happening, semantically speaking.

I don't see the point in converting $# and 0 into numbers before
comparing them.  "!=" is quite more readable, and the old code also
compared the strings.

-- 
David Kastrup