Re: [PATCH] [git-p4] Detect exec bit in more cases.

On Fri, Sep 21, 2007 at 02:15:10PM -0700, Junio C Hamano wrote:

Simon Hausmann [off-list ref] writes:

quoted

On Friday 21 September 2007 00:53:52 Junio C Hamano wrote:

quoted

David Brown [off-list ref] writes:

quoted

On Wed, Sep 19, 2007 at 09:03:50PM +0200, Simon Hausmann wrote:

quoted

On Wednesday 19 September 2007 20:15:03 David Brown wrote:

quoted

git-p4 was missing the execute bit setting if the file had other
attribute bits set.
---

I'm fine with this, so unless you find a better way:

Acked-By: Simon Hausmann <redacted>

I sent out an improved version of this patch yesterday
[ref] that I'd like to get
approved.  I guess I'm not quite sure what happens at this point with a
patch.

I still have that *768445* message as "the last one proposed as
better than previous ones" in my mbox.

Simon?

Indeed, the new improved version is much better :)

Acked-By: Simon Hausmann <redacted>

Thanks.  This should go to 'maint' (part of v1.5.3.3) right?

Sounds good by me.  I've been using it on a few other repos, and haven't
had any problems.

David