Re: [PATCH] git-svnimport: Use separate arguments in the pipe for git-rev-parse
From: Dan Libby <hidden>
Date: 2016-06-15 22:43:36
Possibly related (same subject, not in this thread)
- 2016-06-15 · Re: [PATCH] git-svnimport: Use separate arguments in the pipe for git-rev-parse · Dan Libby <hidden>
- 2016-06-15 · Re: [PATCH] git-svnimport: Use separate arguments in the pipe for git-rev-parse · Matthias Urlichs <hidden>
- 2016-06-15 · Re: [PATCH] git-svnimport: Use separate arguments in the pipe for git-rev-parse · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCH] git-svnimport: Use separate arguments in the pipe for git-rev-parse · Matthias Urlichs <hidden>
- 2016-06-15 · Re: [PATCH] git-svnimport: Use separate arguments in the pipe for git-rev-parse · Dan Libby <hidden>
Hi, it worked for the small test case. I am trying it on the large repo now, and will let you know how it turns out. thanks! On Tuesday 18 September 2007 01:47, Matthias Urlichs wrote:
quoted hunk ↗ jump to hunk
Signed-Off-By: Matthias Urlichs <redacted> --- Please tell me whether that works for you. Somebody else, preferably its author, can fix git-svn. ;-)diff --git a/git-svnimport.perl b/git-svnimport.perl index d3ad5b9..aa5b3b2 100755 --- a/git-svnimport.perl +++ b/git-svnimport.perl@@ -633,7 +633,7 @@ sub commit { my $rev; if($revision > $opt_s and defined $parent) { - open(H,"git-rev-parse --verify $parent |"); + open(H,'-|',"git-rev-parse","--verify",$parent); $rev = <H>; close(H) or do { print STDERR "$revision: cannot find commit '$parent'!\n"; --1.5.2.5
-- Dan Libby Open Source Consulting San Jose, Costa Rica http://osc.co.cr phone: 011 506 223 7382 Fax: 011 506 223 7359