Re: Latest builtin-commit series

On Tue, 2007-09-18 at 15:25 -0700, Junio C Hamano wrote:

Kristian Høgsberg [off-list ref] writes:

quoted

Better late than never:

      * rebase to Pierres strbuf changes.  Note, there is still some
        strbuf tweaking required, to let stripspace work on a strbuf.
        Also, I changed the semantics of stripspace to always add a
        newline if the last line doesn't have one.  I believe the
        current odd semantics (always remove the last newline) comes
        from not being able to easily add a newline, but now that it's a
        strbuf, that's easy.

I do not find the "remove trailing newline" so odd.  Didn't it
come because you sometimes needed to _not_ add it?

All users add a trailing newline if it's not present after stripping.

quoted

      * Set the test suite default editor to '/bin/true' instead of ':'.
        Since we're not exec'ing the editor from shell anymore, ':'
        won't work.  Maybe we should special case ':' in launch_editor
        or perhaps make launch_editor use system(3).  Not sure.

We've had a few threads on the list about what to do with:

	GIT_EDITOR='emacs -nw'

I think David's 08874658b450600e72bb7cb0d0747c1ec4b0bfe1
(git-sh-setup.sh: make GIT_EDITOR/core.editor/VISUAL/EDITOR
accept commands) is a sensible to deal with this issue, and
prefer to see the same semantics kept in the C version.

Ok, I'll take a look at that commit.

Kristian