Thread (9 messages) flat view 9 messages, 4 authors, 2016-06-15

Re: [PATCH 1/3] git-apply: fix whitespace stripping

From: David Kastrup <hidden>
Date: 2016-06-15 22:43:35

"J. Bruce Fields" [off-list ref] writes:
On Tue, Sep 18, 2007 at 10:55:25AM +0200, David Kastrup wrote:
quoted
As far as I can see, this does not really work since it does not
maintain an idea of a current column.

If you have

abcd<four spaces><tab><four spaces><tab>

then indeed the resulting conversion needs to be <tab><tab><tab>
whereas with

abc<four spaces><tab><four spaces><tab>

the resulting conversion needs to be just <tab><tab>
Note that this code *only* handles whitespace in the initial indent;
processing stops as soon as it hits anything other than a tab or an
indent.

Given that, I believe the proposed patch is correct.  Am I missing
something else?
Don't think so.  Sorry for the noise.

-- 
David Kastrup
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help