Re: commit summary, --pretty=short and other tools

Johannes Schindelin wrote:

Hi,

On Tue, 18 Sep 2007, Andreas Ericsson wrote:

quoted

const char *find_commit_subject_end(const char *commit_msg)
{
	const char *dot, *paragraph_end;
		paragraph_end = strstr(commit_msg, "\n\n");
	dot = strchr(commit_msg, '.');
		return min_non_null(dot, paragraph_end); }

would probably get it right very nearly always.

Counterexample (not even mentioning the missing handling of NULL):

Well, pseudo code doesn't have to handle NULL's, as it never gets bad
pseudo-input ;-)

http://brick.kernel.dk/git/?p=qemu.git;a=commit;h=eb66d86e295cd5a8f13221589806e15db62a62fa

And no, the responsible developer showed a strong unwillingness to adapt 
to better tools and workflows.

Hmm, how about any interpunctuation char or newline followed by newline or
the first dot?

It would cover this case and not be overly hard to code.

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231