Re: [PATCH] git.__remotes_from_dir() should only return lists

On 2007-09-06 08:38:26 -0400, Pavel Roskin wrote:

On Thu, 2007-09-06 at 13:26 +0200, Karl Hasselström wrote:

quoted

Thanks. But I guess an even nicer fix would be to make this
function return a set in the first place.

Fine with me. But it was returning a list or None, so the simplest
fix was to return a list in all cases.

Oh, your fix is excellent to fix the immediate problem. I was just
trying to say that making this function (an a heap of others) return
sets would be a useful refactoring.

quoted

Hmm. I don't believe I saw t1001 break without this patch (I run
the test suite before I push, but I might have made a mistake of
course). Does the user's environment leak into the test sandbox?

I don't think it's the user environment, at least on my side. I'm
using Fedora 7, which has python-2.5-12.fc7. That's the error from
the t1001 before my patch:

OK. I'll try to reproduce it when I get home, but it certainly looks
like I only _thought_ I'd run the test suite.

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle