Thread (3 messages) 3 messages, 2 authors, 2016-06-15

Re: [PATCH 1/3] Export format_commit_message()

flat view

From: René Scharfe <hidden>
Date: 2016-06-15 22:43:33

Johannes Schindelin schrieb:
quoted
-static long format_commit_message(const struct commit *commit,
-		const char *msg, char **buf_p, unsigned long *space_p)
+long format_commit_message(const struct commit *commit, const void *template,
+                           char **buf_p, unsigned long *space_p)
I am quite sure that this breaks compilation in C++.

Besides, "format" is so much more descriptive here IMHO.  What is so wrong 
with "format" for you?
I have nothing against naming the parameter "format", actually.  This
name simply didn't occur to me -- weird but true. :-]

René
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help