Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] git-filter-branch: document --original option

From: David Kastrup <hidden>
Date: 2016-06-15 22:43:31

Junio C Hamano [off-list ref] writes:
Junio C Hamano [off-list ref] writes:
quoted
I agree we do not give the "portable to version 7" prize
anymore.  But you made me realize another thing.

I think it should make sure orig_namespace has one and only one
trailing slash, because otherwise "--original refs/heads//"
would lead you to the same disaster.
Perhaps,

	orig_namespace=$(expr "$OPTARG/" : '\(.*[^/]\)/*$')/
See separate proposal which I find still prettier (and which does not
fork).

But I really don't think we should bend over backwards: multiple end
slashes have explicit manual origin.  People deserve what they get
then.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help