Re: [RFC/PATCH] gitweb: Enable transparent compression form HTTP output

On Sun, Aug 26, 2007 at 12:09:29AM CEST, Jakub Narebski wrote:

On Sat, Aug 25, 2007, Petr Baudis wrote:

quoted

On Wed, Jul 25, 2007 at 08:39:43PM CEST, Jakub Narebski wrote:

quoted

quoted

Check if PerlIO::gzip is available, and if it is make it possible to

It doesn't really check if the require succeeded. Either the description
or (preferrably, but not a showstopper, IMO) the code should be
adjusted.

It does not check if require succeeded (I could do that this way),
but instead checks if $PerlIO::gzip::VERSION is defined (if it is true).

our $enable_transparent_compression = !! $PerlIO::gzip::VERSION;

Whoops, I completely missed this chunk.

 Bareword "PerlIO::gzip::VERSION" not allowed while "strict subs" in use at /home/pasky/WWW/repo/gitweb.cgi line 26.

-- 
				Petr "Pasky" Baudis
Ever try. Ever fail. No matter. // Try again. Fail again. Fail better.
		-- Samuel Beckett