Re: call external editor from git-gui?

Hello,

Jan Hudec wrote:

On Tue, Aug 14, 2007 at 09:00:00 +0200, Karl Hasselström wrote:

quoted

On 2007-08-14 00:55:11 -0400, Shawn O. Pearce wrote:

quoted

Spawning the user's preferred editor would be a nice way to get some
of that.

Mmm. I wouldn't call it a _nice_ way: popping up an external program
just to get the right text editing behavior. More like the _only_ way,
if the user is picky enough.

It might actually have a rather serious twist. Often the editor for
git-commit would use the terminal git-commit runs on. But for git-gui you may
not have any terminal (running git-gui from context menu of some file
manager) and even if you do, the user does not expect it to be used. So the
user may -- and quite often will -- want different editors for running from
git-gui and git-commit.

Alternatively you need to find out/let the user specify if her editor
needs a terminal and then use

	xterm -e myfavoriteeditor

or simply

	myfavoriteeditor

depending on the result.

Best regards
Uwe

-- 
Uwe Kleine-König

$ dc -e "5735816763073014741799356604682P"