Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: merge-recursive: do not rudely die on binary merge

From: Chris Shoemaker <hidden>
Date: 2016-06-15 22:43:29

On Tue, Aug 14, 2007 at 03:33:07PM -0700, Junio C Hamano wrote:
When you try to merge a path that involves binary file-level
merge, merge-recursive died rudely without cleaning up its own
mess.  A files added by the merge were left in the working tree,
but the index was not written out (because it just punted and
died), so it was cumbersome for the user to retry it by first
running "git reset --hard".

This changes merge-recursive to still warn but do the "binary"
merge for such a path; leave the "our" version in the working
tree, but still keep the path unmerged so that the user can sort
it out.
Very nice. Thanks, Junio.  As an additional convenience, it would be
nice to make the "theirs" version easily accessible.  Perhaps, by
leaving an untracked file in the working tree, with the original
filename, suffixed with a hash-prefix.  Or alternatively,
cut-n-pastable instuctions on stdout for replacing the file with the
"theirs" version.

On the other hand, I tend to think that "theirs" would be a better
default than "ours" anyway - still leaving the path unmerged, of
course.

-chris
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help