Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] diff: don't run pager if user asked for a diff style exit code

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:29

René Scharfe [off-list ref] writes:
As Wincent Colaiuta found out, it's a bit unexpected for git diff to
start a pager even when the --quiet option is specified.  The problem
is that the pager hides the return code -- which is the only output
we're interested in in this case.

Push pager setup down into builtin-diff.c and don't start the pager
if --exit-code or --quiet (which implies --exit-code) was specified.
Surprisingly nice, although I would have said "don't use
git-diff wrapper from scripts, use underlying diff-* plumbing"
;-).

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help