Thread (2 messages) 2 messages, 2 authors, 2016-06-15

Re: [PATCH] builtin-bundle create - use lock_file

From: Mark Levedahl <hidden>
Date: 2016-06-15 22:43:28

Possibly related (same subject, not in this thread)

Junio C Hamano wrote:
When you exit before committing lockfiles
you hold, atexit handler rolls back and unlink them for you.

The following might be a better replacement.

By the way, by using lockfile's "create temporary, generate into
it and then rename to final", we are allowing an overwrite of an
existing bundle, which we did not allow earlier.  Is this check
something we would want to preserve?
  
Ack - yours is much better. Thanks for the lesson. Also, the former behavior of not allowing overwrite of an existing file was (at least in my opinion) very un-git'ish so I am happy to see that go.

Mark
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help