Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [RFC/PATCH 2/2] gitweb: Add an option to show size of blobs in the tree view

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:25

Jakub Narebski [off-list ref] writes:
So you think that ";opt=-l" would be required to have 'tree' view with 
blob (file) sizes, and it would be allowed only if 
gitweb_check_feature('ls-tree-size') is true (or something like that).
Should we return "Permission denied" or simply ignore "-l" extra option 
if it is prohivited by the config?
I would say we should make config show-tree-entry-size (or
whatever name) unconditionally give the object size of the tree
entry, and drop ";opt=-l in URL" support from the code.  In
other words, if the site/repo owner wants to show it, it is
shown to everybody, otherwise nothing is shown.

Keeping the URL clean and without needless variations would help
caching; I do not see major advantage of this feature one way or
the other, so if we can keep a tree view of the same object from
the same repository the same by removing one user preference,
that would be better.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help