Re: [PATCH] git-sh-setup.sh: make GIT_EDITOR/core.editor/VISUAL/EDITOR accept commands

Junio C Hamano [off-list ref] writes:

It is not just "won't apply".  What if GIT_DIR had spaces (which
is fine) and single-quotes in it?  Wouldn't it percolate down to
$@ because it becomes the leading directory of the temporary
file name?  And you quote '"$@"' and eval it, now what happens?

Ah, I spoke too fast.  It is fine --- the shell that actually is
doing the eval then interpolates "$@".  Clever.