Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: git-gui-i18n: Make "Revert changes in these $n files" translatable.

From: Christian Stimming <hidden>
Date: 2016-06-15 22:43:24

Quoting Brett Schwarz [off-list ref]:
quoted
quoted
- Buttons in hard reset confirmation (branch->revert or merge->abort,
  and it is yes/no dialog).
Maybe those need to be translated in the tcl/tk system libraries?
These are indeed in the Tk libs. Unfortunately, there is no straight  
 forward way to change the button text for tk_messageBox. I'll   
probably submit a patch to Tcl core for this.
That would indeed be a very good solution here.
In the mean time, if this is important, there are 2 ways around this:

1) override the button text in the msgcat. (...)
So, somewhere in the git-gui, you would  have to do something like:
    namespace eval ::Tk {
      ::msgcat::mcset en_us &OK <new_term>
      ::msgcat::mcset en_us &Cancel <new_term>
      ::msgcat::mcset en_us &Yes <new_term>
      ::msgcat::mcset en_us &No <new_term>
      <continue for each language, if needed>
    }
I think this wouldn't help much here. First of all, the original  
messages might be different between different Tcl versions. But  
secondly and more importantly, as Harri Ilari pointed out, we should  
prefer to provide button texts different from Yes/No but rather  
questions like "Revert"/"Cancel".
2) Re-write the tk_messageBox, to include an option to specify the   
button text. This wouldn't be too hard actually, but this would live  
 with git-gui.
This would indeed be the nicer solution and it would improve both the  
English button labels and their translations all in one.
I don't think option #1 is robust enough, but would be the easiest   
approach. Note also that this would only be for unix platforms,   
since for windows and Mac, it calls the platform's equivalent.
By the way: I have been using git-gui on Windows with mingw-git(+msys)  
and ActiveTcl for several weeks by now. Works like a charm, and I'm  
looking forward to propose it as a fully localized, fully  
cross-platform, and simply the best SCM, to the co-workers in my  
company... :-)

Christian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help