Re: [PATCH] gitk: let you easily specify lines of context in diff view

On Jul 26, 2007, at 2:34 PM, Paul Mackerras wrote:

Steffen Prohaska writes:

quoted

More lines of context sometimes help to better understand a diff.
This patch introduces a text field above the box displaying the
blobdiffs. You can type in the number of lines of context that
you wish to view.

Nice idea!  I suggest you use a spinbox instead of an entry though,
since that has up and down buttons, and allows you to restrict the
value to an integer.

Thanks. Will try that.

quoted

   * I don't know how to update the view after entering a new value.

You can put a trace on the associated variable and specify a function
to be called when the variable's value changes.  Grep for "trace add
variable" in gitk to see how it's done.

This is already included in the patch but I don't know which of gtk's
procs to call to update the view. gitk would need to execute git diff
and update the text box in the bottom left. I tried 'dodiffindex'
but this causes corruptions of the history view.

	Steffen