Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 3/5] Clean up work-tree handling

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:24

Matthias Lederhofer [off-list ref] writes:
I try to take a closer look at your changes tomorrow evening.  Here
are just two short things I saw while taking a short look at the
patch.

Johannes Schindelin [off-list ref] wrote:
quoted
+const char *get_git_work_tree(void)
+{
+	static int initialized = 0;
+	if (!initialized) {
+		work_tree = getenv(GIT_WORK_TREE_ENVIRONMENT);
+		if (!work_tree) {
+			work_tree = git_work_tree_cfg;
+			if (work_tree && !is_absolute_path(work_tree))
+			work_tree = git_path(work_tree);
A tab is missing here.
I think xstrdup() is missing here, too.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help