Re: [PATCH] Fix git_mkstemp to return an error when path is too long.
From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:43:24
Hi, On Thu, 26 Jul 2007, Carlos Rica wrote:
quoted hunk ↗ jump to hunk
@@ -79,12 +80,14 @@ int git_mkstemp(char *path, size_t len, const char *template) pch += 5; } else { size_t n = snprintf(pch, len, "%s/", env); - + if (n >= len) + return -2;
That is certainly a bug fixed (even if few people have an insanely long TMPDIR...)
len -= n; pch += n; } - strlcpy(pch, template, len); + if (strlcpy(pch, template, len) >= len) + return -2;
Maybe just "return error("filename too long: %.*s", 60, pch);"? So that
all callers to git_mkstemp() get the message for free?
Ciao,
Dscho