Re: [PATCH] Teach the --cover-letter option to format-patch

On Tue, 24 Jul 2007, Peter Oberndorfer wrote:

On Tuesday 10 July 2007 19:20, Johannes Schindelin wrote:

quoted

Hi,

On Tue, 10 Jul 2007, Daniel Barkalow wrote:

quoted

I think this is missing the ultra-important "extra_headers" stuff, which 
is what makes my messages actually reach the right people. That's why 
I'd like the code shared for generating headers (except for Subject) for 
a rev_info between the code that does it for patch messages and the code 
for the cover letter. I think it's also missing making [PATCH 1/N] a 
reply to it if the series is set up as replies.

Ah yes. Both issues should be relatively easy to integrate into my patch.

quoted

I like the design, in any case. I want the blurb actually stored in the 
objects directory somehow, so that I don't have to trawl through my sent 
email for it when I send the series again for some reason, but that's a 
relatively straightforward extension to your code. (Read an object with 
a hash and stick the text in instead of the ***...*** parts.)

I do not understand. But then, my patch should be a good starting point. 
Go wild.

Ciao,
Dscho

Anybody working on this?
Somebody, *cough* convinced me into working on this.
I already split up the existing patch into logic parts, and will now try to read message / header
from file or a commit.

Last night, I was thinking about it, but I hadn't actually gotten started. 
If you do it, I'd suggest using an unsigned tag for the message rather 
than a commit, since it fits the design for a message in an unsigned tag 
(extra information about the tagged version).

	-Daniel
*This .sig left intentionally blank*