Re: If NEEDS_LIBICONV is set for Solaris 8, it does not build git for me

Thomas Glanzmann [off-list ref] writes:

     [ Paul and Jason CCed because they touched that section last ]

Patch is appended at the very bottom of the E-Mail. I have a fully
patched Solaris 8 with Forte 11. In order to get git compile I had to
delete the

	NEEDS_LIBICONV = YesPlease

line from the Makefile in the Solaris 8 section.

In a distant past when I built git on an otherwise unused Sol8
at work I recall I needed that.  I do not think that machine
used Forte compiler, though.

Regarding 5.8 vs 5.9 (dis)similarity, I suspect that other three
are there in the version specific section only because people
who needed them had access to only that version, and everybody
played safe.  I would be for example very surprised if NO_SETENV
were unneeded on Solaris 5.7, given that both 5.8 and 5.9 need
it (if it is unneeded on 5.7 that would mean Sun dropped setenv
when they went to 5.8).

We currently handle only three cases for Solaris in the
Makefile, meaning that we consider that Solaris world is
fragmented in three factions: just "SunOS", 5.8 or 5.9.

I suspect that a blanket statement "Solaris 8 needs (or does not
need) NEEDS_LIBICONV" would not hold true.  It probably depends
on many other things (perhaps OS patchlevel, extra packages, C
compiler suite).  The best course of action is for interested
Solaris users to get together, list combinations of possible
variations that are available to them and they care about, and
see which make variable is needed where, and refine the current
"three-faction fragmentation", which apparently does not reflect
reality.

Unfortunately I am not in a position to best judge how Solaris
world is fragmented.