Re: [PATCH] git-gui: Allow users to set commit.signoff from options.

On Sun, Jul 08, 2007 at 05:48:32PM -0400, Shawn O. Pearce wrote:

Gerrit Pape [off-list ref] wrote:

quoted

Users may want to automatically sign-off any commit for a specific
repository.  If they are mostly a git-gui user they should be able to
view/set this option from within the git-gui environment, rather than
needing to edit a raw text file on their local filesystem.

Sure.  But your patch to git-gui actually just lets the user set
the flag, but doesn't make git-gui honor it.  So the user can set
"Automatically Sign-Off" through git-gui but it will have no effect
within git-gui (git-gui doesn't use git-commit.sh, it has its own
pure-Tcl implementation).

Ups, sorry.

I'm not applying this to git-gui, for the very same reason that
Junio already gave as to why he won't apply the git-commit.sh patch.

Within git-gui adding a signoff is either one mouse click (the
button on the toolbar), a single keystroke (Ctrl-S) or a menu action
(Commit->Signoff).  Three easy ways to insert the signoff line.
But it still needs to be a choice from the user, every time they
make a commit.

Yes, thanks, Gerrit.