Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH] merge-tree: sometimes, d/f conflict is not an issue

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:20

Junio C Hamano [off-list ref] writes:
Johannes Schindelin [off-list ref] writes:
...
quoted
Okay, so you're saying that merge-recursive should use the aggressive 
strategy?
I do not think so.  Isn't the whole "see if there are renames" thing
depend on threeway_merge() not resolving "one side removes other
side leaves intact" case itself?  Aggressive resolves it saying
"Ok that is a remove", which risks it to miss the case in which
that the side that apparently "removed" the path in fact moved
it somewhere else.

The last time I looked at merge-recursive's D/F check, I found
that it was not quite doing things right.  I may be able to dig
up what I posted to the list...
It was from around April 7th-10th this year.

    http://thread.gmane.org/gmane.comp.version-control.git/43970/focus=44158
    http://thread.gmane.org/gmane.comp.version-control.git/43971/focus=43997

I think the case described in the latter message is almost the
opposite case of what your patch tries to deal with.

In the web interface of

    http://news.gmane.org/gmane.comp.version-control.git

the patch series that led to my complaints are at around page 76
for me.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help