Re: [PATCH] revision: allow selection of commits that do not match a pattern

Hi,

On Sat, 7 Jul 2007, Sven Verdoolaege wrote:

On Sat, Jul 07, 2007 at 05:27:23PM +0100, Johannes Schindelin wrote:

quoted

I suspect that with this patch,

	git rev-list --not --grep bugfix HEAD

does not work as expected. Why?

Well... I guess that depends on what you expect...

Well, at least you hopefully that it is confusing. To use --not for grep 
patterns _as well_ as for revision arguments.

quoted

Why not make "git rev-list --grep '!bugfix' HEAD" work?

Yes, you would have to have a special exception that the prefix "!!" 
actually matches an exclamation mark, but I'd be willing to live with 
that.

Hmm... what if you want to (not) match anything starting with
one or more '!' ?

Yeah, that would not work.

How about I add a '--invert-match' option that would
apply to all following match options?
Or we could escape the '!' with backslash.

If we want to match it at the beginning. Yes, that sounds more reasonable 
to me.

Ciao,
Dscho