Thread (4 messages) flat view 4 messages, 1 author, 2016-06-15
DORMANTno replies

[StGIT PATCH 2/3] Disallow non-patch args to "stg show" (gna #8453).

From: Yann Dirson <hidden>
Date: 2016-06-15 22:43:18
Subsystem: the rest · Maintainer: Linus Torvalds

Git-core refs and patch@branch args were not allowed in the
multiple-argument form of "stg show".  For consistency we completely
disallow them: git-core refs are available from git-show, and "stg
show patch@branch" as "stg show patch -b branch".

Signed-off-by: Yann Dirson <redacted>
---

 stgit/commands/show.py |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/stgit/commands/show.py b/stgit/commands/show.py
index c59ac68..3bf4f20 100644
--- a/stgit/commands/show.py
+++ b/stgit/commands/show.py
@@ -55,12 +55,7 @@ def func(parser, options, args):
     elif len(args) == 0:
         patches = ['HEAD']
     else:
-        if len(args) == 1 and args[0].find('..') == -1 \
-               and not crt_series.patch_exists(args[0]):
-            # it might be just a commit id
-            patches = args
-        else:
-            patches = parse_patches(args, applied + unapplied, len(applied))
+        patches = parse_patches(args, applied + unapplied, len(applied))
 
     if options.diff_opts:
         diff_flags = options.diff_opts.split()
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help