Thread (6 messages) flat view 6 messages, 4 authors, 2016-06-15

Re: [PATCH] Ignore end-of-line style when computing similarity score for rename detection

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:43:18

Possibly related (same subject, not in this thread)

I wonder if we have a path or the attribute cue at this point of
the operation.  Your patch may solve that special case of CRLF
mangled files, but diffcore-delta works both on text and binary
and I am not sure what damange/side-effect you are causing.

And you are not ignoring "\r\n vs \n difference" as the comment
claims, but are discarding '\r' unconditionally.  When we start
doing something like that, I would feel much better if we _know_
we are operating on a text file at least.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help