Thread (11 messages) flat view 11 messages, 5 authors, 2016-06-15

Re: Mark Levedahl's gitk patches

From: Paul Mackerras <hidden>
Date: 2016-06-15 22:43:18

Junio C Hamano writes:
I took a look at differences between your gitk.git and what I
have.  It appears that our "proc readrefs" differ a bit.

Most notably, the global hash tagcontents is read when readrefs
run in the version I have, while gitk.git version fills it
lazily in showtag, where it is actually used.  Because you read
the refs using "show-ref -d", you do not need to do extra forks
to figure out the objects referred to by the tags in your code.
Yes, that was one of the many improvements I made.  Basically I pulled
a lot of stuff over from the 'new' branch.
I think what you have is a lot better from interactive latency
point of view.  I'll take the version from gitk.git and push the
results out.
Thanks.  I have now pushed out Mark Levedahl's two bug fixes as well.

Paul.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help