[this patch depends on the one I posted here:
http://marc.info/?l=git&m=118280134031923&w=2 ]
Without this patch, git-rev-list unnecessarily omits strerror(errno)
from its diagnostic, upon write failure:
$ ./git-rev-list --max-count=1 HEAD > /dev/full
fatal: write failure on standard output
With the patch, git reports the desired ENOSPC diagnostic:
fatal: write failure on standard output: No space left on device
* builtin-rev-list (show_commit): Don't fflush stdout here.
Instead, let the fclose in main do it, so there's a better
chance the underlying cause (errno) will be reported.
Signed-off-by: Jim Meyering <redacted>
---
builtin-rev-list.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/builtin-rev-list.c b/builtin-rev-list.c
index 813aadf..62f0ba9 100644
--- a/builtin-rev-list.c
+++ b/builtin-rev-list.c
@@ -100,7 +100,6 @@ static void show_commit(struct commit *commit)
printf("%s%c", buf, hdr_termination);
free(buf);
}
- fflush(stdout);
if (commit->parents) {
free_commit_list(commit->parents);
commit->parents = NULL;