Thread (4 messages) flat view 4 messages, 2 authors, 2016-06-15

Re: [PATCH] git-gui: use "blame -w -C -C" for "where did it come from, originally?"

From: Shawn O. Pearce <hidden>
Date: 2016-06-15 22:43:17

Junio C Hamano [off-list ref] wrote:
The blame window shows "who wrote the piece originally" and "who
moved it there" in two columns.  In order to identify the former
more correctly, it helps to use the new -w option.
...
quoted hunk
diff --git a/lib/blame.tcl b/lib/blame.tcl
index 139171d..a412a8c 100644
--- a/lib/blame.tcl
+++ b/lib/blame.tcl
@@ -672,7 +672,7 @@ method _read_blame {fd cur_w cur_d cur_s} {
 		close $fd
 		if {$cur_w eq $w_asim} {
 			_exec_blame $this $w_amov @amov_data \
-				[list -M -C -C] \
+				[list -w -C -C] \
 				{ original location}
 		} else {
 			set current_fd {}
I've wanted to do this since you introduced `git blame -w`.  But I
can't use it, because I cannot trust that -w is there.  For example
it is not in maint, but the new blame viewer from git-gui is.

Apply my --list-features patch to core Git and I'll activate -w in
git-gui when --list-features claims the 'blame-ignore-whitespace'
feature is available.

;-)

-- 
Shawn.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help